[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 3967 in lilypond: Patch: Pitch alterations use
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 3967 in lilypond: Patch: Pitch alterations use SCM rather than flower rationals |
Date: |
Mon, 21 Jul 2014 07:40:30 +0000 |
Updates:
Labels: -Patch-push
Comment #14 on issue 3967 by address@hidden: Patch: Pitch alterations use SCM
rather than flower rationals
http://code.google.com/p/lilypond/issues/detail?id=3967
Well, I'm currently entangled with a few other things. I agree with Devon
that this change is not really helping readability.
I'm putting the main part on wait for now but will push the first two
cleanup commits. Since they are no user-visible change, they don't really
need to be verified by the patch team.
Pushed those to staging as
commit 98b5d41f6eee82aa7cb9da7dbfafdd35872830bd
Author: David Kastrup <address@hidden>
Date: Tue Jun 24 12:56:22 2014 +0200
Don't call Pitch::Pitch with more arguments than necessary.
commit 3d43c213f307c2a2aad27c8933801cd4dae02f90
Author: David Kastrup <address@hidden>
Date: Tue Jun 24 20:48:15 2014 +0200
Pitch::Pitch (int, int) is declared but not defined
This caters for the definition by making the last argument of
Pitch::Pitch (int, int, Rational) a default argument.
Once they are through, I'll rebase on master, upload the reduced regtest
for the final commit, let it get checked and then change status to
Patch-wait.
Then only the main theme of this patch will remain dormant for now.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings