Re: [Lilypond-auto] Issue 4384 in lilypond: Patch: Remove convert-ly rule \shiftOff -> \undo\shiftOn

[lilypond]

Comment #9 on issue 4384 by address@hidden: Patch: Remove convert-ly rule  
\shiftOff -> \undo\shiftOn
https://code.google.com/p/lilypond/issues/detail?id=4384

Well, there is really nothing worthwhile for automatic testing since the  
Patch just removes one rule action for convert-ly and that rule is very  
well separated from anything else.  So there is really nothing at all to  
test here, only to discuss.

The reversal of the rule should be accompanied with a cleanup of the  
affected documentation files.  In fact, the documentation files should be  
cleaned up even when keeping the rule, the only difference being that with  
the rule kept it would be unsafe to also rewind the version numbers.

That cleanup will be too late for the currently rolling release I think.   
So we still have a two-week time window to get that under wraps.  The  
cleanup would warrant Patchy testing once it is prepared: while it is  
simple to do, it will be mostly manual and manual changes have the  
potential for accidents.

So at any rate: thanks for testing this, and sorry for not having made  
clearer that this effort would likely have been better spent on a different  
phase of cleaning up.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings