[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 4421 in lilypond: Patch: Make music functions
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 4421 in lilypond: Patch: Make music functions callable from Scheme |
Date: |
Tue, 09 Jun 2015 14:21:17 +0000 |
Updates:
Labels: -Patch-countdown Patch-new
Comment #16 on issue 4421 by address@hidden: Patch: Make music functions
callable from Scheme
https://code.google.com/p/lilypond/issues/detail?id=4421
This mainly addresses the points of Keith's critique where feasible.
Several proposals were inadvisable or based on wrong assumptions: I've
put in extensive documentation in order to make this more obvious.
Apart from slight code arrangement and lots of documentation, I also
removed functionality from the Fluid class that has
shoot-yourself-in-the-foot potential, and I fixed a slight error in the
fallback for printing of notenames without accessible parser.
I don't see this change/review as warranting a stop of the countdown unless
Keith (or anybody else) is of different opinion. So I'll put it back to
countdown once it passes testing.
http://codereview.appspot.com/244840043
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Re: [Lilypond-auto] Issue 4421 in lilypond: Patch: Make music functions callable from Scheme, lilypond, 2015/06/10