lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New feature: automatically invert chords or drop/rise chord notes (i


From: v . villenave
Subject: Re: New feature: automatically invert chords or drop/rise chord notes (issue 365840043 by address@hidden)
Date: Wed, 23 Jan 2019 13:51:01 -0800

That’s a great idea; I hadn’t considered it.  I ought to add it to the
regtest then…

Oh.  I’ve just noticed that although it does works with simple \dropNote
and \raiseNote commands, it makes a mess of nested commands (and
therefore \invertChords).  I was careful not to overwrite a possibly
already-set 'octavation for that exact reason, but it looks like my math
was off.


https://codereview.appspot.com/365840043/diff/60001/scm/modal-transforms.scm
File scm/modal-transforms.scm (right):

https://codereview.appspot.com/365840043/diff/60001/scm/modal-transforms.scm#newcode335
scm/modal-transforms.scm:335: (ly:music-transpose
On 2019/01/23 21:14:56, dak wrote:
Shouldn't this also set/adjust the octavation property so that
ChordNames
context and similar still recognize the original \chordmode chord in
spite of
the revoicing?

Done.

https://codereview.appspot.com/365840043/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]