Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?'

[Knut Petersen]

On 24.01.19 14:04, David Kastrup wrote:
> Masamichi Hosoda <address@hidden> writes:
>
> > > This is a gs 9.26 issue and I cannot see how this might be related to what we 
> > > have hit here, so maybe Hosoda-san will be abel to figure why make check is 
> > > breaking without extractpdfmark installed.
> > If I understand correctly, this patch solves the error.
> >
> > ```
> > --- a/scripts/build/output-distance.py
> > +++ b/scripts/build/output-distance.py
> > @@ -652,7 +652,7 @@ class SignatureFileLink (FileLink):
> >                   data_option = ''
> >                   if options.local_data_dir:
> >                       data_option = 
> > ('-slilypond-datadir=%s/share/lilypond/current '
> > -                                   % dir)
> > +                                   % (cur_dir + '/' + dir))
> Is dir guaranteed to be a relative path?

In master we already have a fix. Gub is current master + pull requests 53-60 + temporary fix for the unrelated gslib9 bug described yesterday, running on openSuSE Tumbleweed. Additionally I configured and fired up a local git-daemon that provides a clone of the lilypond repository to gub because 
"LILYPOND_REPO_URL=file://..." overrides are not supported in current gub.

Here's the test log.

Try stable/2.20 in the hope to reproduce the bug:

   make LILYPOND_REPO_URL=git://golem/lilypond.git LILYPOND_BRANCH=stable/2.20 
lilypond

That fails with

[...]

   1287 below threshold
   919 unchanged
   invoking rm -rf 
/home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1
   mkdir /home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1
   mkdir 
/home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1/v2.21.0-1
   mkdir 
/home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1/v2.19.81-1
   v2.19.81-1/rest-positioning.ly -> 
/home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1/v2.19.81-1/rest-positioning.ly
   v2.21.0-1/rest-positioning.ly -> 
/home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1/v2.21.0-1/rest-positioning.ly
   invoking gs -sDEVICE=png16m -dGraphicsAlphaBits=4 -dTextAlphaBits=4 
-slilypond-datadir=v2.19.81-1/share/lilypond/current   -r101 
-dAutoRotatePages=/None 
-sOutputFile=/home/knut/sources/gub/uploads/webtest/v2.21.0-1/compare-v2.19.81-1/v2.19.81-1/rest-positioning.png
 -dNOSAFER -dEPSCrop -q
   -dNOPAUSE v2.19.81-1/rest-positioning.eps  -c quit
   Error: /undefinedfilename in --file--
   Operand stack:
   (share/lilypond/current/fonts/otf/emmentaler-20.otf)   (r)
   Execution stack:
       %interp_exit   .runexec2   --nostringval-- --nostringval--   
--nostringval--   2   %stopped_push --nostringval--   --nostringval--   
--nostringval--   false 1   %stopped_push   1999   1   3   %oparray_pop   1998  
 1 3   %oparray_pop   --nostringval--   1982   1   3 %oparray_pop   1868   1  
   3   %oparray_pop   --nostringval-- %errorexec_pop   .runexec2   
--nostringval-- --nostringval--   --nostringval--   2   %stopped_push 
--nostringval--
   Dictionary stack:
       --dict:1214/1684(ro)(G)--   --dict:0/20(G)-- --dict:82/200(L)--
   Current allocation mode is local
   Last OS error: No such file or directory
   Current file position is 424
   GPL Ghostscript 9.21: Unrecoverable error, exit code 1
   Traceback (most recent call last):
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 1349, in ?
        main ()
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 1346, in main
        compare_tree_pairs (zip (args[0::2], args[1::2]), out, 
options.threshold)
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 1061, in compare_tree_pairs
        data.create_html_result_page (dest_dir, threshold)
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 1043, in create_html_result_page
        link.link_files_for_html (dest_dir)
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 660, in link_files_for_html
        to_compare = self.create_images (dest_dir)
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 650, in create_images
        system (cmd)
      File 
"/home/knut/sources/gub/target/linux-64/src/lilypond-golem--lilypond.git-stable-2.20/scripts/build/output-distance.py",
 line 1091, in system
        assert stat == 0
   AssertionError
   Traceback (most recent call last):
      File "test-lily/rsync-test.py", line 221, in ?
        main ()
      File "test-lily/rsync-test.py", line 215, in main
        compare_test_info (options)
      File "test-lily/rsync-test.py", line 186, in compare_test_info
        compare_test_tarballs (options, versions_found[-3:])
      File "test-lily/rsync-test.py", line 136, in compare_test_tarballs
        system (cmd)
      File "test-lily/rsync-test.py", line 87, in system
        raise Exception ('fail')
   Exception: fail
   make[3]: *** [unlocked-test-export] Fehler 1
   make[3]: Leaving directory `/home/knut/sources/gub'
   make[2]: *** [cached-test-export] Fehler 2
   make[2]: Leaving directory `/home/knut/sources/gub'
   make[1]: *** [test-export] Error 2
   make[1]: Leaving directory `/home/knut/sources/gub'
   make: *** [lilypond] Error 2

Great. I can reproduce the problem.

After that I created branch stabletest. stabletest is stable/2.20 with 3 
additional commits cherry-picked commits from master:

   commit 2c7277e0014b8d1d22ef5a1caa69a2f86bcfb964
   Author: Werner Lemberg <address@hidden>
   Date:   Sun Jan 20 07:17:51 2019 +0100

        output-distance.py: Correctly change directories.

   commit 430fcf895a49d8159413f194488b8474d4ae6be6
   Author: Werner Lemberg <address@hidden>
   Date:   Sat Jan 5 10:20:46 2019 +0100

        Issue 5456: output-distance.py: Support relative font paths

        This is needed for forthcoming gub changes (i.e., to compare regression
        tests built with different gub incarnations).

   commit 61d42c83db9abf567da0dcabec50df71d56d2bf9
   Author: Werner Lemberg <address@hidden>
   Date:   Mon Dec 3 11:25:35 2018 +0100

        Issue 5444: Make PDF generation preserve links with recent ghostscript 
versions

        As explained in bug report

          https://bugs.ghostscript.com/show_bug.cgi?id=699830

        `gs' by default produces PDFs suited for printing.  To better follow 
the PDF
        specification, created PDFs no longer contain links in the standard 
setup.
        To preserve links in generated PDFs, command line option 
`-dPrinted=false'
        must be thus added to `ps2pdf' and friends.

        For simplicity, all calls to ghostscript get this option even if not
        strictly necessary.

Try to build stabletest with gub:

   make LILYPOND_REPO_URL=git://golem/lilypond.git LILYPOND_BRANCH=stabletest 
lilypond

That succeeds.  As lilypond stable/2.20 needs to be compatible with recent 
versions of gs and gub I see no real problem and recommend to cherry-pick the 
three patches into stable/2.20.

Knut