Re: I cannot run make check since Issue 5450: relocate.cc: Introduce new command `set?'

[David Kastrup]

Masamichi Hosoda <address@hidden> writes:

>>>> This is a gs 9.26 issue and I cannot see how this might be related to what 
>>>> we have hit here, so maybe Hosoda-san will be abel to figure why make 
>>>> check is breaking without extractpdfmark installed.
>>>
>>> If I understand correctly, this patch solves the error.
>>>
>>> ```
>>> --- a/scripts/build/output-distance.py
>>> +++ b/scripts/build/output-distance.py
>>> @@ -652,7 +652,7 @@ class SignatureFileLink (FileLink):
>>>                  data_option = ''
>>>                  if options.local_data_dir:
>>>                      data_option = 
>>> ('-slilypond-datadir=%s/share/lilypond/current '
>>> -                                   % dir)
>>> +                                   % (cur_dir + '/' + dir))
>>>
>> 
>> Is dir guaranteed to be a relative path?
>
> It seems that there is no guarantee.
> But, `make check` invokes `output-distance` with relative paths.
> http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=GNUmakefile.in;h=da1f6f64e088756e07d20f8e1603ccc3a102053e;hb=HEAD#l340
>
> Therefore, `dir` is also a relative path.
> There seems to be no place invoking `output-distance` other than that.

Python has os.path.join that should allow to combine cur_dir with either
relative or absolute paths.

-- 
David Kastrup