[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: add markup objects overview (issue 357930043 by address@hidden)
|
From: |
v . villenave |
|
Subject: |
Re: Doc: add markup objects overview (issue 357930043 by address@hidden) |
|
Date: |
Thu, 24 Jan 2019 12:39:08 -0800 |
Thanks a lot Werner! You caught quite a few things I should have dealt
with more rigorously.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely
File Documentation/notation/text.itely (right):
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode50
Documentation/notation/text.itely:50: @cindex Text objects
On 2019/01/21 06:18:35, lemzwerg wrote:
Any specific reason why you use uppercase? Wouldn't
@cindex text objects
be sufficient?
Done.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode51
Documentation/notation/text.itely:51: @cindex Markup objects
On 2019/01/21 06:18:35, lemzwerg wrote:
BTW, I think you should also add
@cindex objects, markup
for completeness.
Done.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode63
Documentation/notation/text.itely:63:
On 2019/01/21 06:18:35, lemzwerg wrote:
Grammatical nitpick: If you have a list of items, either do
Yes. I hesitated between the two, since I’m already using semi-colons
before "see also" (I was reluctant to add another just afterwards). On
the other hand, since the introductory sentence ends with a colon, all
that follows is clearly part of the same sentence. Oh well.
* Frob nicate.
Didn’t know that one, thanks :-)
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode82
Documentation/notation/text.itely:82: in any definition inside the
@code{\header} block (e.g.
On 2019/01/21 06:18:35, lemzwerg wrote:
Mid-sentence abbreviations that end with a full dot should have a
trailing '@:'
to get correct whitespace. In this case, however, I would write
'e.g.,'
Done.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode83
Documentation/notation/text.itely:83: @var{title}, @var{subtitle},
@var{composer}), or in some
On 2019/01/21 06:18:35, lemzwerg wrote:
s/@var/@code/
Those header block elements are not variable
Hm… You’re right. But they’re not really properties either (not in the
sense of music-props or context-props.
I’m gonna write
"specific elements defined inside the @code{\paper} block".
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode85
Documentation/notation/text.itely:85: @var{evenHeaderMarkup} for page
numbers. This is explained in
On 2019/01/21 06:18:35, lemzwerg wrote:
Ditto.
Right; I ought to remember that @var is not for variables.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode89
Documentation/notation/text.itely:89: @noindent
On 2019/01/21 06:18:35, lemzwerg wrote:
I don't see a necessity for '@noindent'. You actually start a new
paragraph,
don't you?
I guess you could see it that way (and it actually makes more sense).
In my view, I was prolonging the list (and ditto below) by mentioning
_other_ places where \markup may be used. But you’re right, splitting
into new paragraphs is cleaner.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode119
Documentation/notation/text.itely:119: @noindent
On 2019/01/21 06:18:35, lemzwerg wrote:
Ditto.
Done.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode122
Documentation/notation/text.itely:122: @var{text} property if it has
one, or its @var{stencil} property. Some of
On 2019/01/21 06:18:35, lemzwerg wrote:
s/@var/@code/
Done.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode148
Documentation/notation/text.itely:148: \once \override NoteHead.text =
\markup \lower #0.5 "NoteHead"
On 2019/01/21 06:18:35, lemzwerg wrote:
Please check the PDF output; I guess that some lines in your example
are too
wide.
Done.
https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode641
Documentation/notation/text.itely:641: Extentind LilyPond:
On 2019/01/21 06:18:35, lemzwerg wrote:
s/Extentind/Extending/
Oh, dear.
https://codereview.appspot.com/357930043/