Re: LYNX-DEV multiple bookmark support and popup/radion_button in 'o'ptions. 0.09

[Hiram Lester, Jr.]

On Wed, 27 Nov 1996, Filip M Gieszczykiewicz wrote:

> Greetings. Eeek.. I forgot to upload the patch for that. So sorry.
> It's up to 0.09 and the key fix is line #521 or so, fix up the test to
> be:

If Fote doesn't get around to it, I'll try to get it in over the holidays.

> Problem is array range.. c gets 'A' subtracted from it by c = TOUPPER(c) - 'A'
> and then becomes the index for an array... (bonehead bug comes in) 13-'A'
> is a negative number... and WHAMO!

That could be a very bad thing. :)  Again, I see HP-UX is more tolerant
and doesn't core dump.  Even Linux wasn't core dumping only crashing.

> > Also, one other thing that should probably be cleaned up is that the
> > second screen of bookmark files when editing the files is shifted one line
> > down from the first screen, and it looks slightly awkward when flipping
> > back and forth between screens.
> 
> Geez :-) I thought I'd get away with that. You know, I wrote it and I
> can't track it down (why it happens). I think the part that decides
> how many lines to show per screen has some int-division problems.
> 
> It's really noticable when you have a 9 row display (I tried), first screen
> has 3 entries, second and on ONLY 2...  Shoot me! :-)

I'll try to take a look at it this weekend if Fote doesn't get it before I
do. :)

I also discovered another oddity probably left over from the single
bookmark file code.  When you are viewing bookmark file A and add a link
from it to another bookmark file, you cannot 'r'emove the bookmark from
file A without 'v'iewing file A again.  This was probably in the original
code to prevent you from adding a bookmark and trying to remove one
without reloading the page.  Reloading won't help this one either.  This
behavior might seem normal if you were adding a bookmark to the current
bookmark file, but not to a different file...

   +------------------------------------+-------------------------------+
   | Hiram W. Lester, Jr.               | E-Mail: address@hidden    |
   | Computer Science                   | Home page:                    |
   | Middle Tennessee State University  |   http://pobox.com/~hwlester/ |
   +------------------------------------+-------------------------------+

;
; To UNSUBSCRIBE:  Send a mail message to address@hidden
;                  with "unsubscribe lynx-dev" (without the
;                  quotation marks) on a line by itself.
;