Re: LYNX-DEV multiple bookmark support and popup/radion_button in 'o'ptions. 0.09

[Hiram Lester, Jr.]

On Wed, 27 Nov 1996, Filip M Gieszczykiewicz wrote:

> Greetings. Eeek.. I forgot to upload the patch for that. So sorry.
> It's up to 0.09 and the key fix is line #521 or so, fix up the test to
> be:
> 
>         if (c == 13)
>                 if (TLJ_A_subbookmark[0])
>                         /* TLJ 11/12/96 - bug nailed right about here... */
>                         return(0); /* TLJ - assumes default action on ENTER */
>                 else
>                         return (-1);

Ok, I found this bug.  Fote's code uses the more efficient switch/case
structure, and the bug is right here in assuming that the enter key will
return a code 13.  On Linux it's sending a line feed (10) which makes the
array out of bounds and crashes the StrAllocCopy.  I would assume that
this is why Enter on HP-UX is saying undefined bookmark on Enter.  The fix
is simply to add a case 10: with the case 13:.  I'm gonna have a look at
fixing one other little problem before I package it up and put it in the
composite...  Fote's working on things this afternoon as well (not sure if
he even got any turkey :) ), so I may try to coordinate with him before
releasing the composite.  Will keep you posted...

   +------------------------------------+-------------------------------+
   | Hiram W. Lester, Jr.               | E-Mail: address@hidden    |
   | Computer Science                   | Home page:                    |
   | Middle Tennessee State University  |   http://pobox.com/~hwlester/ |
   +------------------------------------+-------------------------------+

;
; To UNSUBSCRIBE:  Send a mail message to address@hidden
;                  with "unsubscribe lynx-dev" (without the
;                  quotation marks) on a line by itself.
;