Re: LYNX-DEV v2.7 pre-release

[Bela Lubkin]

Foteos Macrides wrote:

> 02-03-97
> * Today's distribution is a pre-release of v2.7.  The projected official
>   release date is 02-15-97.  All header, help and documentation files,
>   and the top directory name, have been updated for v2.7. - FM

I built this on SCO OpenServer Release 5 with no changes whatsoever,
just "make sco5".  (Now I'm fooling with userdef.h; that was just a
preliminary test run...)

The build had three warnings, two of which were expected, all in
src/LYCurses.c.  Below is a context diff which corrects these.  One
warning was caused by:

        (void) setterm((char *)ttytype + 4);

SCO's <curses.h> defines setterm's argument as unsigned char *.  It also
defines ttytype as unsigned char [].  Therefore, removing the cast fixes
this warning.  If the cast was put there because of problems on other
systems, they will be re-exposed; but I suspect it was just someone
"being careful".

The other warnings are due to VMS-specific "#ifndef THIS$THAT" ifdefs;
SCO's cc says:

  "LYCurses.c", line 489: warning: tokens ignored at end of directive line

gcc -ansi says:

  LYCurses.c:489: warning: garbage at end of `#ifdef' argument

I fixed these by moving them out to a separate header file.

>Bela<

=============================================================================

*** LYCurses.c.orig     Tue Jan  7 17:09:36 1997
--- LYCurses.c  Tue Feb  4 07:33:08 1997
***************
*** 394,400 ****
       *  Get terminal type (strip 'dec-' from vms style types).
       */
      if (strncmp((CONST char*)ttytype, "dec-vt", 6) == 0) {
!       (void) setterm((char *)ttytype + 4);
      }
  #endif /* !NO_TTYTYPE */
  
--- 394,400 ----
       *  Get terminal type (strip 'dec-' from vms style types).
       */
      if (strncmp((CONST char*)ttytype, "dec-vt", 6) == 0) {
!       (void) setterm(ttytype + 4);
      }
  #endif /* !NO_TTYTYPE */
  
***************
*** 486,497 ****
  #endif /* system */
  #include <processes.h>
  
! #ifndef CLI$M_TRUSTED
! #define CLI$M_TRUSTED 64 /* May not be in the compiler's clidef.h     */
! #endif /* !CLI$M_TRUSTED */
! #ifndef LIB$_INVARG
! #define LIB$_INVARG 1409588
! #endif /* !LIB$_INVARG */
  
  #define EFN   0                       /* Event flag                   */
  
--- 486,492 ----
  #endif /* system */
  #include <processes.h>
  
! #include "LYCurses_VMS.h"
  
  #define EFN   0                       /* Event flag                   */
  
*** /dev/null   Tue Feb  4 07:38:39 1997
--- LYCurses_VMS.h      Tue Feb  4 07:37:15 1997
***************
*** 0 ****
--- 1,19 ----
+ #ifndef LYCURSES_VMS_H
+ #define LYCURSES_VMS_H
+ 
+ /*
+  * These #ifndef statements are broken out of LYCurses.c because they
+  * generate warnings with some non-VMS compilers.  The compiler must
+  * parse all of the code in order to know which "#endif" closes the
+  * outer "#ifdef VMS".  Along the way it is annoyed by these non-ANSI
+  * extended tokens.
+  */
+ 
+ #ifndef CLI$M_TRUSTED
+ #define CLI$M_TRUSTED 64 /* May not be in the compiler's clidef.h     */
+ #endif /* !CLI$M_TRUSTED */
+ #ifndef LIB$_INVARG
+ #define LIB$_INVARG 1409588
+ #endif /* !LIB$_INVARG */
+ 
+ #endif /* LYCURSES_VMS_H */
;
; To UNSUBSCRIBE:  Send a mail message to address@hidden
;                  with "unsubscribe lynx-dev" (without the
;                  quotation marks) on a line by itself.
;