lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

LYNX-DEV lynx-2.7.1 bug with XLOADIMAGE_COMMAND


From: sit-local
Subject: LYNX-DEV lynx-2.7.1 bug with XLOADIMAGE_COMMAND
Date: Thu, 12 Jun 1997 15:17:18 EDT

There is a bug in lynx-2.7.1 which causes it to incorrectly parse
the XLOADIMAGE_COMMAND line in the LYNX_CFG file. The broken behavior
currently results in something lynx running something like:

    xli /tmp/L246750TMP.gif &xv  &

since "xli %s &" is the compiled default, but "xv %s &" is the command
in lynx.cfg.

This is a simple bug-fix. Apply (some version of) the appended patch to
lynx/src/LYReadCFG.c.  (I'm not sure that you actually need to FREE the
old one, since none of the other directives which use StrAllocCopy do,
but I think if you don't, you leak.)

*** LYReadCFG.c 1997/05/13 19:07:04     1.1.1.3
--- LYReadCFG.c 1997/06/12 18:37:36
***************
*** 1124,1130 ****
  
        case 'X':
        if (!strncasecomp(buffer, "XLOADIMAGE_COMMAND:", 19)) {
!           StrAllocCat(XLoadImageCommand, (char *)&buffer[19]);
        }
        break;
  
--- 1124,1132 ----
  
        case 'X':
        if (!strncasecomp(buffer, "XLOADIMAGE_COMMAND:", 19)) {
! /*        StrAllocCat(XLoadImageCommand, (char *)&buffer[19]); */
!           FREE(XLoadImageCommand);
!           StrAllocCopy(XLoadImageCommand, (char *)&buffer[19]);
        }
        break;
--
Emil Sit / Bronx Science '95, MIT '99 -- ESG, SIPB, Athena Consulting
Email: address@hidden / Web: http://web.mit.edu/sit/www/
PGP KeyID: 0xE63561E9 / Fingerprint:  A68FD0693EDABA19  2671EC1F22498F58
;
; To UNSUBSCRIBE:  Send a mail message to address@hidden
;                  with "unsubscribe lynx-dev" (without the
;                  quotation marks) on a line by itself.
;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]