Re: LYNX-DEV -color/-nocolor development confusion

[T.E.Dickey]

> On Tue, 22 Jul 1997, T.E.Dickey wrote:
> [kw:]
> > > Neither your code nor devel ac-0.38 always show the current status
> > > (whether color or not) correctly on the Options Screen.
> 
> > Actually the slang version does (afaik) show the state correctly - at least
> > when I'm testing it 
> 
> The slang version of which code, and which version?
I've got 0.99-38 (though I think we're talking about two different things;
you're talking about the initial state of the toggle, which may/may not be
right - that logic is set up in Lynx).
 
> > (perhaps the slang library is exploiting the particular
> > color model of the XFree86 xterm - I didn't check that aspect yet, since
> > slang doesn't work well with non-bce color models).  For SVr4 curses (and
> > ncurses), an additional refresh is still needed (I was looking into this to
> > see if there's a cleaner way than clearing the screen first - there are
> > some minor differences between SVr4 curses vs ncurses in this area, but
> > both have this problem).
> 
> I hardly understand a word of this.  But you seem to be talking about
> something different.  What I mean:
> 
> With 2.7.1ac-0.38, compiled --with-screen=ncurses:
> 
>    TERMINFO=/usr/local/share/terminfo TERM=vt100 lynx
> Lynx comes up in mono, as expected.  But invoking the 'O'ptions Screen
> displays:
>    show color (&)  : ON
> 
> 
> With fotemods 1997-07-21, compiled with make solaris2-slang:
> 
>    TERMINFO=/usr/local/share/terminfo TERM=linux lynx
> Lynx comes up in color, as expected.  But invoking the 'O'ptions Screen
> displays:
>    show color (&)  : OFF
I've got it set to 'ON' (but that's because the initial value is set
in userdefs.h)

> (And this line itself appears in the COLOR:0 of my choice, contradicting 
> itself.)
> 
> I am not talking about what happens when I try to change anything,
> just what is shown immediately after going to the 'O'ptions screen.
> Am I misunderstanding what "show color" is supposed to mean?
probably - but that's ok.  As I implemented it, "show color" was just
a flag that would suppress the ability of Lynx to display in color.
I did not focus on setting the flag's state automatically from the
terminal's ability to display color (an oversight ;-).
 
> > > You have changed the function of that new Options Screen setting
> > > (and of the LYShowColor variable) significantly: in Tom's code it only
> > > applies for his color-curses, not for slang color.  In Tom's code it
> > > can only be used to force color OFF (against what terminfo says).  In
> 
> > uh, no - it's a two-way toggle (crude, but a ^L helps it along).
> > I could "fix" it by using a goto as does the ^L code....
> 
> With your code you cannot use the "show color (&)" toggle to force
> color ON if the terminal type does not support color, that's what I
> mean.  It is used as an additional condition for actually "doing" color,
> as in "if (lynx_uses_color && LYShowColor)", you cannot turn on color
> handling by toggling LYShowColor if has_colors() doesn't allow it.
> Do you have any disagreement with that?
that's reasonable - I should add (like the dot files toggle) some logic to
make the option more reasonable.
 
> > > - A -nocolor flag that works for both slang and curses.
> > >   [currently: FM-no, TD-for curses only]
> > I did try that a little for slang, but it doesn't work yet.
> >  
> > > - Options screen toggle should work the same for slang and curses color
> > >   support, as far as possible.  The reservation means that for curses
> > >   color, one cannot turn color on if the terminal description says that
> > >   the terminal doesn't support color.
> > >   [currently: FM-no, TD-no]
> > right (I'm not done with this change - but I thought it would be useful).
> 
> (Here you seem to agree with what I tried to say above.)
right.  It's proof-of-concept, subject to polishing (e.g., the initial
state of the toggle, the screen update after changing the toggle, etc).

-- 
Thomas E. Dickey
address@hidden
http://www.clark.net/pub/dickey
;
; To UNSUBSCRIBE:  Send a mail message to address@hidden
;                  with "unsubscribe lynx-dev" (without the
;                  quotation marks) on a line by itself.
;