lynx-dev messy code

[Philip Webb]

980827 Thomas Dickey wrote: 
> 980826 Nelson Henry Eric wrote:
> > Could you easily explain what "hidden away in macros" means?
> A couple of examples:
> 
>   + the way I cleaned up the clutter in LYOptions.c -
>   moving repetitive code into macros.

there seems to be a lot of it about: have a look at LYSearch.c 158-385
the twin sections  if (recall ...  &  else if (recall ... .
 
>   + the cleanup of the temporary file handling functions
>   (instead of plastering the code with #if VMS/#else/#if DOSPATH/#else/...,
>   move structurally-similar stuff into macros or functions.
>   (When I'm reading code, a preprocessor line is distracting).
 
i suspect a lot of Lynx code was in fact written rather hastily. 
that's no criticism of the authors, but we shouldn't be too in awe of it.

-- 
========================,,============================================
SUPPORT     ___________//___,  Philip Webb : address@hidden
ELECTRIC   /] [] [] [] [] []|  Centre for Urban & Community Studies
TRANSIT    `-O----------O---'  University of Toronto