lynx-dev 2.8.1 Pre 2 Problems on VMS

[newsmgr]

                RE Lynx 2-8-1 Pre2, Patched for Cookie problems

        I tried to build this version of lynx on two VMS systems:--

System 1 - VAX VMS 5.5-2, VAX C 3.2, UCX 4.1
============================================

This came to a dead stop with this error. VARARGS.h is in
SYS$LIBRARY and contains things like....
/*
 * Definitions for access to variable length argument lists
 */

#ifdef __STDARG_LOADED
#undef __STDARG_LOADED
#pragma NOSTANDARD
#undef va_start
#undef va_arg
#undef va_end
#pragma STANDARD
#else
typedef char *  va_list;
#endif

#define va_dcl                  int     va_alist;
#define va_count(count)         vaxc$va_count (&count)
#define va_start_1(ap, offset)  ap = (va_list) ((int) &va_alist + (offset))

#define va_start(ap)            ap = (va_list) &va_alist
#define va_arg(ap, type)        (ap = (va_list) ((int) ap + ((sizeof (type) + 
3) & ~3)), \
 * (type *) ((int) ap - ((sizeof (type) + 3) & ~3)))
#define va_end(ap)              ap = (va_list) 0

#endif                                  /* __VARARGS_LOADED */


HTVMS_WAISUI                                                    27-SEP-1998 
11:18:38    VAX C      V3.2-044                 Page 28
V1.0                                                             6-AUG-1998 
06:28:22    HTVMS_WAISUI.C;1 (1)
11462           bit_map*
11463           makeBitMap(unsigned long numBits, ...)
11464           /* construct and return a bitmap with numBits elements */
11465           {
11466    1        va_list ap;
11467    1        long i,j;
11468    1        bit_map* bm = NULL;
11469    1      
11470    1        va_start(ap,numBits);
%CC-W-TOOMANYMACARGS, Argument list for macro "va_start" contains
                too many arguments;  excess arguments ignored.
 
%CC-E-UNDECLARED, "va_alist" is not declared within the scope of
                this usage.
 
%CC-E-INVOPERAND, Invalid operand of a "& (address-of)" operator.
 
11471    1      
11472    1        bm = (bit_map*)s_malloc((size_t)sizeof(bit_map));
11473    1        bm->size = (unsigned long)(ceil((double)numBits / 
bitsPerByte));



System 2 - Alpha VMS 7.1, DEC C 5.7, UCX 4.1
============================================

This failed with two fatal errors, I guessed some fixes and was able to get
a working version.

Source Listing                  27-SEP-1998 11:53:54  DEC C V5.7-004
25-SEP-1998 20:41:38  [UTIL.LYNX2-8-1.SRC]GRIDTEXT.C;1

          25228 #include <LYUtils.h>
          25397 #include <LYStrings.h>
       X  26005 #include <LYStructs.h>
          26006 #include <LYGlobalDefs.h>
          26363 #include <LYGetFile.h>
          26395 #include <LYSignal.h>
          26403 extern void *VMSsignal PARAMS((int sig, void (*func)()));
                .............1                                            
%CC-E-NOTCOMPAT, (1) In this declaration, the type of "VMSsignal" is not 
compatible with the type of a previous declaration of "VMSsignal" at line 
number 170 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYCURSES.H;1.

          26411 #include <LYMail.h>
          26438 #include <LYList.h>
          26449 #include <LYCharSets.h>
          26912 #include <LYCharUtils.h>        /* LYUCTranslateBack... */
       X  27019 #include <UCMap.h>
       X  27020 #ifdef EXP_CHARTRANS_AUTOSWITCH

This function was defined in other files as :--

******************************
UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYCURSES.C;1

 *                      VMSsignal() added for handling both Ctrl-C *and* Ctrl-Y
 *      VMSSIGNAL -- Fote Macrides 29-Jun-1993
 *              The equivalent of VMSsignal(SIGINT, cleanup_sig) is done on
 *              VMSsignal(SIGINT, SIG_DFL) is treated as a call to ttclose().
 *              Call VMSsignal(SIGINT, SIG_IGN) before system() calls to
 *               VMSsignal(SIG_INT, cleanup_sig) on return from the subprocess.
 *               and VMSsignal() is just a "helper", also not a full emulation.
PUBLIC void VMSsignal (sig,func)
     VMSsignal(SIGINT, SIG_IGN);
     VMSsignal(SIGINT, cleanup_sig);

******************************
UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYCURSES.H;1

extern void VMSsignal PARAMS((int sig, void (*func)()));

******************************
UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYSIGNAL.H;1

extern void *VMSsignal PARAMS((int sig, void (*func)()));
***************
So I made a guess and removed the '*'



      3   29815                 /*
      3   29816                  *  JIS X0201 Kana in JIS support. - by ASATAKU
      3   29817                  */
      3   29818                 case S_jisx0201_text:
      4   29819                 if (ch == '\033') {
      4   29820                     text->state = S_esc;
      4   29821                     text->kanji_buf = '\0';
      4   29822                     return;
      4   29823                 } else {
      4   29824                     text->kanji_buf = '\216';
                ......................................1       
%CC-I-INTCONSTTRUNC, (1) In this statement, conversion of the 
integer constant "'\216'" to char type will cause data loss.

      4   29825                     ch |= 0200;
      3   29826                 }
      3   29827                 break;
      2   29828         }
      2   29829 

After I fixed a broken comment in LYPrint the compile and link completed,
 these were the other warnings etc...

$ cc [-.Implementation]SGML.c

    JISx0201TO0208_EUC('\216', I, OHI, OLO);
.......................^
%CC-I-INTCONSTTRUNC, In this statement, conversion of the integer constant 
"'\216'" to unsigned char type will cause data loss.
at line number 3315 in file 
DISK$UTIL_DISK:[UTIL.LYNX2-8-1.WWW.LIBRARY.IMPLEMENTATION]SGML.C;1


$ cc LYCurses

            HTAlert(MEMORY_EXHAUSTED_ABORT);
............^
%CC-I-IMPLICITFUNC, In this statement, the identifier "HTAlert" is implicitly 
declared as a function.
at line number 1319 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYCURSES.C;1

    longname(dummy, term);
.............^
%CC-W-UNINIT1, The scalar variable "dummy" is fetched but not initialized.
at line number 955 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYCURSES.C;1


$ cc LYMail

        cur, owner_address?owner_address:"<nil>",
........^
%CC-W-OUTTYPELEN, In this statement, the type or size of this argument to 
fprintf is not appropriate for the conversion specifier "%s".  The value might 
be truncated or formatted in an unintended manner.
at line number 606 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYMAIL.C;1

        linkname?linkname:"<nil>");
........^
%CC-I-OUTTOOMANY, In this statement, additional arguments to fprintf are 
provided for which there are no conversion specifiers in the format string.  
Arguments from "linkname?linkname:"<nil>"" onward will be evaluated, but not 
processed by fprintf.
at line number 608 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYMAIL.C;1

This line was associated with a broken comment, it was unclear whether the 
line was intended to be enabled or disabled.
$ cc LYPrint

                    remove_quotes(subject); 
..................................^
%CC-W-NOTCONSTQUAL, In this statement, the referenced type of the pointer value 
"subject" is const, but the referenced type of the target of this assignment is 
not.
at line number 717 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYPRINT.C;2

$ cc LYReadCFG

                Define_VMSLogical(tbl->name, value);
..................................^
%CC-W-NOTCONSTQUAL, In this statement, the referenced type of the pointer value 
"tbl->name" is const, but the referenced type of the target of this assignment 
is not.
at line number 1138 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYREADCFG.C;1

$ cc LYUtils

                CTRACE(tfp, "...LYRemoveTemp done(%d)%s\n", code,
............................................................^
%CC-W-UNINIT1, The scalar variable "code" is fetched but not initialized.
at line number 5791 in file DISK$UTIL_DISK:[UTIL.LYNX2-8-1.SRC]LYUTILS.C;1

                                Regards
 *      *     *     *     *       Tony Bolton   
****  ****   **     **   **       TBolton 'at' mhl.nsw.gov.au
** **** **   *********   **       MANLY HYDRAULICS LABORATORY.
**  **  **   *********   **       110B King ST. Manly Vale 2093 Sydney AUSTRALIA
**      **   **     **   ******** Phone +61 2 99490200 FAX +61 2 99486185