Re: lynx-dev Another proposed patch

[dickey]

> 
> This one is more serious - it is an attempt to fix a crash.  However, I 
> am uncertain of the ramifications of the particular strings I have chosen. 
> The problem is that in certain cases, the address was null, so the fprintf 
> was crashing. 

I agree that it's a potential hole: but which configuration does this?
Perhaps the problem is upstream, and we should not have a null pointer
in the first place.  I'd like to know - so we can see if this should be
applied to the 2.8.1 bugfixes.

> --- lynx2-8-2/src/LYShowInfo.c-dist   Sun Nov 22 05:55:18 1998 
> +++ lynx2-8-2/src/LYShowInfo.c        Sun Nov 22 05:58:47 1998 
> @@ -26,7 +26,7 @@ 
>  #if defined(HAVE_CONFIG_H) && !defined(NO_CONFIG_INFO) 
>  #define HAVE_CFG_DEFS_H 
>   
> -#define PutDefs(table, N) fprintf(fp0, "%-35s %s\n", table[N].name, 
> table[N].value) 
> +#define PutDefs(table, N) { int val=N; fprintf(fp0, "%-35s %s\n", 
> (table[val].name ? table[val].name :"Not Found") , (table[val].value ? 
> table[val].value : "None Available")); } 
>   
>  /* 
>   *  Compile-time definitions info, returns local url 

> Larry W. Virden                 <URL:mailto:address@hidden> 

-- 
Thomas E. Dickey
address@hidden
http://www.clark.net/pub/dickey