Re: lynx-dev lynx2.8.2dev.19 patch #7 (Options menu!)

[Leonid Pauzner]

15-Mar-99 20:16 Leonid Pauzner wrote:
> * Forms-based options menu: fix reloading of previous document *only* when
>   necessary (was always, since early forms-based options menu days).
>   Still have a bug - while submitting the options menu lynx reload menu again,
>   but this is much faster to load small local file twice than fetch previous
>   (possible large) document over the net. - LP

Well, I fix this bug forever, so the message should be:

* Forms-based options menu: fix reloading of previous document *only* when
  necessary, to avoid fetching the previous (possible large) document over
  the net. (was *always*, since early forms-based options menu days).
  See exit from postoptions(). - LP


> To see this new bug try toggle trace log before submitting form option menu,
> or probably by eyes if change (links and form fiels are numbered) option.
> I still thik this patch is a real improvement over the old bevaviour.

> Please test whether the prev document updated when changing
> your favourite options - I test it but probably forget 'need_reload' flag
> somethere.

> The patch is against dev.19
> (Tom: please discard my LYOptions.c changes in #6 patch).
And *this* patch against my previous patches, precisely:  #7 (Options menu!)
and also #9 (more comments). It is simple.


diff -u old/lyoption.c ./lyoption.c
--- old/lyoption.c      Tue Mar 16 14:52:24 1999
+++ ./lyoption.c        Tue Mar 16 18:08:46 1999
@@ -3921,12 +3921,19 @@
     WWWDoc.bookmark = newdoc->bookmark;
     WWWDoc.isHEAD = newdoc->isHEAD;
     WWWDoc.safe = newdoc->safe;
+    LYforce_no_cache = FALSE;   /* ! */
+    LYoverride_no_cache = TRUE; /* ! */
+       /*
+        * Working out of getfile() cyrcle we set *no_cache manually here
+        * so HTLoadAbsolute() will return "Document already in memory":
+        * it was forced reloading Options Menu again without this (overhead).
+        *
+        * Probably *no_cache was set in a wrong position because of
+        * the internal page...
+        */
     if (!HTLoadAbsolute(&WWWDoc))
        return(NOT_FOUND);

-    /*** two HTLoadAbsolute() here allow things work correctly,
-     *** sorry for overhead (probably only seen in trace log).
-     ***/

     /*
      *  Return to previous doc, not to options menu!

diff -u old/htaccess.c ./htaccess.c
--- old/htaccess.c      Thu Mar  4 02:39:46 1999
+++ ./htaccess.c        Tue Mar 16 16:11:02 1999
@@ -633,7 +633,7 @@
 /*     Load a document - with logging etc              HTLoadDocument()
 **     ----------------------------------
 **
-**     - Checks or documents already loaded
+**     - Checks for documents already loaded
 **     - Logs the access
 **     - Allows stdin filter option
 **     - Trace ouput and error messages