lynx-dev Re: dev20 (with patch to patch that makes patches :-)

[pg]

In a recent note, address@hidden said:

> Date: Wed, 17 Mar 1999 22:41:42 -0500 (EST)
> 
> 1999-03-17 (2.8.2dev.20)

Thanks for all this.  Just built on Solaris.  Still configuring on OS390
(even though it started first :-).

Hmmm.  With dev.18, SIGTSTP (^Z) didn't work on Solaris.  Now it works
again.  (Wasn't a problem on OS390).  Strange?

> * lots of color style changes, only effective if compiled with 
> USE_COLOR_STYLE;
>   together they seem to make color styles act much more reliably and
>   consistently - KW

Hmmm.  I now get the dreaded monochrome reverse video links on Solaris
with both XTerm and DTTerm, where DTTerm formerly showed color and XTerm
used bold highlighting.  I guess I need to experiment with color styles.

> * add a rule to makefile.in to generate patches - PG

Thank you.  But as soon as I submitted this, it caught the eye of a
reader who asked whether unified diffs are preferred to context diffs.
A couple responses preferred "diff -u"; none spoke in favor of "diff -c"

The attached patch changes to "diff -u".  But beware; "-u" appears not
to be POSIX (I haven't checked).  With the patch, I can no longer
generate patches on OS390, and on Solaris I must force GNU diff in
my path before Solaris diff.  Editor's choice: integrate the patch
or discard it -- I shan't be offended.  :-)

-- gil
===================================================================
* Change "diff -c" to "diff -u".  -PG

%%% Created Thu Mar 18 17:18:02 MST 1999 by target lynx.patch. %%%
diff -bru orig/lynx2-8-2/README lynx2-8-2/README
--- orig/lynx2-8-2/README       Wed Mar 17 20:17:11 1999
+++ lynx2-8-2/README    Thu Mar 18 17:16:32 1999
@@ -142,7 +142,7 @@
    Any messages you wish to post should be sent to address@hidden
    PLEASE use the lynx-dev list, NOT private email to the developers,
    for questions or discussion about Lynx, or contributions of patches.
-   Patches should use the context diff format (diff -c), which can be
+   Patches should use the unified diff format (diff -u), which can be
    generated by building the target, "make lynx.patch" after unpacking
    a pristine copy of the source into a subdirectory called "orig".
 
diff -bru orig/lynx2-8-2/makefile.in lynx2-8-2/makefile.in
--- orig/lynx2-8-2/makefile.in  Wed Mar 17 20:17:11 1999
+++ lynx2-8-2/makefile.in       Thu Mar 18 16:21:23 1999
@@ -290,10 +290,10 @@
                        ( set -x; cd $$I && rm -f *.orig *.rej makefile ); : ); 
\
                done; }
        ( cd $(top_srcdir)/..; echo "%%% Created `date` by target 
address@hidden %%%"; \
-                       diff -brc $(REFDIR) $(lynxdir) ) \
+                       diff -bru $(REFDIR) $(lynxdir) ) \
                | grep -v '^Common' \
                | grep -v '^Binary files ' \
-               | grep -v '^Only ' | tee $@ | grep '^--- $(lynxdir)'
+               | grep -v '^Only ' | tee $@ | grep '^\+\+\+ $(lynxdir)'
 
 install: lynx$x install-bin install-man install-cfg @INSTALL_LSS@
        @echo