Re: lynx-dev A Fatal error has occurred in Lynx Ver. 2.8.2rel.1

[Klaus Weide]

On Fri, 8 Oct 1999, Ruslan R. Laishev wrote:

> OpenVMS 7.1-1h1/Alpha,DEC C 6.0:

> %TRACE-F-NOMSG, Message number 0009804C Q)uit /=search [delete]=history list
>   image    module    routine             line      rel PC           abs PC
>                                             0 0000000000000000 
> FFFFFFFF8090C8E8
>  LYNX  HTSTRING  StrAllocVsprintf       20922 0000000000001488 
> 000000000013B3F8
>  LYNX  HTSTRING  HTSprintf0             21055 00000000000018DC 
> 000000000013B84C
>  LYNX  LYMAINLOOP  exit_immediately_with_error_message
>                                         33967 00000000000105C8 
> 00000000000FF6A8
> A Fatal error has occurred in Lynx Ver. 2.8.2rel.1

Function exit_immediately_with_error_message had problems that
have since been fixed in 2.8.3dev code the relevand difference
is probably

OLD:
        HTSprintf0(&buf, "%s\n%s %s\n",
                   buf2,
                   gettext("lynx: Can't access startfile"),
                   /*
                    * hack: if we fail in HTAccess.c
                    * avoid duplicating URL, oh.
                    */
                   strstr(buf2, gettext("Can't Access")) ? "" : startfile);

NEW:
        HTSprintf0(&buf, "%s\n%s %s\n",
                   buf2 ? buf2 : "",
                   gettext("lynx: Can't access startfile"),
                   /*
                    * hack: if we fail in HTAccess.c
                    * avoid duplicating URL, oh.
                    */
                   (buf2 && strstr(buf2, gettext("Can't Access"))) ?
                                                               "" : startfile);


and similarly in the block below that.

    -----

The new 2.8.3dev code still has a problem though: near the end,

     fprintf(stderr, buf);
     ....
     printf(buf);

should be

     fprintf(stderr, "%s", buf);
     ....
     printf("%s", buf);

instead.  The string in buf may contain '%' characters, which will easily
cause a crash as it is now.

   Klaus