Re: lynx-dev megapatch to dev.10 - and a rant

[Leonid Pauzner]

14-Oct-99 08:28 Klaus Weide wrote:
> On Thu, 14 Oct 1999, Vlad Harchev wrote:

>>  I tried to apply your patch to dev10. It fails to compile since
>> 'src/TRSTable.c' includes non-existing file 'AC.c'. Can you make it available
>> (if you make that file available separately, I will be even more thankful to
>> you).

> Very sorry about that. It is only one function that I moved to a separate
> file for testing, and then completely forgot about.  The contents are
> appended, if should just replace the `#include "AC.c"' in TRSTable.c.


Thanks this contribution, Klaus, seems this 'megapatch' is a great 2.8.3
improvement (I need more expirience to be familiar with real tables on the
net, though). I have applied you patch onto dev11 without noticeble problems.

Two minore tips from DJGPP/gcc2.8.1 build:

../../Library/Implementation/HTAnchor.c: In function 
`HTAnchor_findSimpleAddress':
../../Library/Implementation/HTAnchor.c:455: warning: assignment discards 
`const' from pointer target type

and


GridText.c: In function `display_line':
GridText.c:923: parse error before `char'
GridText.c:1102: `LastDisplayChar' undeclared (first use in this function)
GridText.c:1102: (Each undeclared identifier is reported only once
GridText.c:1102: for each function it appears in.)
make.exe: *** [GridText.o] Error 1

This happen with PDCurses (no NCURSES_VERSION defined), so a fix:

--- gridtext.old        Fri Oct 15 04:26:24 1999
+++ gridtext.c  Fri Oct 15 13:03:24 1999
@@ -901,6 +901,7 @@
     char buffer[7];
     char *data;
     size_t utf_extra = 0;
+    char LastDisplayChar = ' ';
 #ifdef USE_COLOR_STYLE
     int current_style = 0;
 #define inunderline NO
@@ -920,7 +921,6 @@
 #ifndef NCURSES_VERSION
     text->has_utf8 = NO; /* use as per-line flag, except with ncurses */
 #endif
-    char LastDisplayChar = ' ';

     /*
      *  Set up the multibyte character buffer,