Re: lynx-dev [patch] more SH_EX tweak

[Hiroyuki Senshu]

Hello, lynx-dev.

Klaus Weide wrote:
>On Sun, 17 Oct 1999, Leonid Pauzner wrote:
>
>> Playing with SH_EX defined on non-Windows platform detected:
>> 
>> 
>> * Tweak LYExecv() to exclude SH_EX conditional (dired commands didn't work
>>   on non-Windows platforms when SH_EX defined).
>
>Since you are using SH_EX on a non-Windows platform - I am curious
>what are the benefits.  Could you give some examples how that
>changes lynx's behavior in a noticeable way?
>
>   Klaus

It answers some doubts.

Of course, SH_EX is not Windows exclusive use.
A code is being written on the assumption that 
even the UNIX like OS is used.

I am making LYNX with the following environment.

  o Borland C++ compiler
  o Microsoft Visual C++ compiler
  o Cygnus Cygwin (egcs, gcc compiler)

In other words, _WINDOWS doesn't sometimes come into 
being on Cygwin.

Because of this, a very complex condition judgment is done.
Of course, there may be some coming off omissions.
It asks for an opinion about the point.


-------- * ------ * ------- * -------

As for present dev.12, some modification is done.
/* !!! */ A movement was unstable under the condition 
that a part wasn't changed.

Teach me the reason why this part was removed.

---
diff -Bur lynx283.d12/WWW/Library/Implementation/HTString.c 
lynx283.w32/WWW/Library/Implementation/HTString.c
--- lynx283.d12/WWW/Library/Implementation/HTString.c   Fri Oct 15 23:05:52 1999
+++ lynx283.w32/WWW/Library/Implementation/HTString.c   Fri Oct 15 23:10:50 1999
@@ -763,6 +763,8 @@
        char **         pstr = va_arg(ap, char **);
        CONST char *    fmt  = va_arg(ap, CONST char *);
 #endif
+       if (pstr != 0)  /* !!! */
+           *pstr = 0;
        result = StrAllocVsprintf(pstr, 0, fmt, &ap);
     }
     va_end(ap);
diff -Bur lynx283.d12/src/LYMainLoop.c lynx283.w32/src/LYMainLoop.c
--- lynx283.d12/src/LYMainLoop.c        Fri Oct 15 23:06:00 1999
+++ lynx283.w32/src/LYMainLoop.c        Fri Oct 15 23:14:18 1999
@@ -4628,7 +4628,7 @@
        }
 #if defined(CJK_EX)    /* 1997/12/13 (Sat) 15:20:18 */
        if (HTCJK == JAPANESE) {
-           *last_kcode = NOKANJI;      /* AUTO */
+           last_kcode = NOKANJI;       /* AUTO */
        }
 #endif
        LYforce_no_cache = TRUE;  /*force the document to be reloaded*/
---

--Hiroyuki

--
Shonai College of Industry and Technology.
Electronics and Computer Infomation Course.
E-mail: address@hidden