Re: lynx-dev lynx2.8.3dev.14

[Klaus Weide]

On Wed, 3 Nov 1999, T.E.Dickey wrote:

> 1999-11-03 (2.8.3dev.14)
> * modify no_color_video check for A_UNDERLINE so it is active for any
>   combination that uses underlining (reported by KW) -TD

Either you misunderstood me, or you disagree completely...
What I wanted was quite the opposite of what you did.
Your change:

--- 2.8.3dev.13/src/LYCurses.c  Wed Oct 13 08:24:23 1999
+++ 2.8.3dev.14/src/LYCurses.c  Wed Nov  3 19:41:39 1999
@@ -520,14 +520,17 @@
        attr = lynx_color_cfg[code].attr;

        /*
-        * no_color_video isn't implemented (97/4/14) in ncurses 4.1, but may
-        * be in SVr4 (which would make this redundant for the latter).
+        * no_color_video is implemented in ncurses 4.2, but not in other
+        * flavors of curses.  So we check before adding video attributes that
+        * might conflict with colors.  For A_BOLD, check for both the bold and
+        * standout mask items because standout often uses bold in conjunction
+        * with another attribute.  -TD
         */
        if ((Current_Attr & A_BOLD) && !(NoColorVideo & 33)) {
                attr |= A_BOLD;
        }

-       if ((Current_Attr == A_UNDERLINE) && !(NoColorVideo & 2)) {
+       if ((Current_Attr & A_UNDERLINE) && !(NoColorVideo & 2)) {
                attr |= A_UNDERLINE;
        }


My wish (and the only thing that makes sense, IMO):

-       if ((Current_Attr & A_BOLD) && !(NoColorVideo & 33)) {
-               attr |= A_BOLD;
-       }
-
        if ((Current_Attr == A_UNDERLINE) && !(NoColorVideo & 2)) {
                attr |= A_UNDERLINE;
        }

(not a real patch - just hand-made to convey the idea)
i.e. get completley rid of adding A_BOLD here, and leave A_UNDERLINE
as it was.

 Klaus