Re: lynx-dev dev.16 patch 1

[Leonid Pauzner]

1-Dec-99 11:44 Leonid Pauzner wrote:
> Since Tom introduce LYGetNewline()/LYSetNewline()
> and I completely forgot about yet another Newline initialization in
> GridText.c, I made the next step for partial display code simplification.
> Lots of (-) below.

Uh, DISP_PARTIAL code normally relay on 'newdoc'
while SOURCE_CACHE - on 'curdoc', so partial mode while loading
cached sources will be broken by this patch.
Wrong newline position will be displayed for this marginally not visible
case - only for slow machines. Please do not applay this patch until we
find a proper fix [this is the other instance of 'curdoc' vs LYK_WHEREIS
problem in partial mode].
Sorry.

> * remove global Newline_partial, use LYGetNewline() instead.



> diff -u old/gridtext.c ./gridtext.c
> --- old/gridtext.c      Wed Dec  1 08:15:20 1999
> +++ ./gridtext.c        Wed Dec  1 09:28:20 1999
> @@ -46,10 +46,6 @@

>  #undef DEBUG_APPCH

> -#ifdef DISP_PARTIAL
> -#include <LYMainLoop.h>
> -#endif
> -
>  #ifdef SOURCE_CACHE
>  #include <HTFile.h>
>  #endif
> @@ -8082,10 +8078,7 @@
>             FREE(HTMainAnchor->source_cache_file);
>             return FALSE;
>         }
> -#ifdef DISP_PARTIAL
> -       display_partial = display_partial_flag;  /* restore */
> -       Newline_partial = LYGetNewline();  /* initialize */
> -#endif
> +
...