Re: lynx-dev [PATCH] "change directory" command

[Vlad Harchev]

On Tue, 18 Jul 2000, Ismael Cordeiro wrote:

> On Mon, 17 Jul 2000, Vlad Harchev wrote:
> 
> > > It seems that Thomas is right, your patch broke something. In the prompt
> > > "D)ownload, or C)ancel" the "c" and "C" commands don't work anymore.
> > > Commenting out "#define "SUPPORT_CHDIR" in userdefs.h, as suggested in
> > > the CHANGES file, doesn't re-enable the commands above.
> > 
> >  It's not my patch's failure - Tom overlooked something in HTFWriter.c, the
> > fix for this attached.
> 
> Anyway, your patch fixed it and the problem was corrected in dev.5/dev.6.

 No, Tom wrote his version of the fix that differs from mine - his version
won't allow Ctrl-C as synonim for C in the "D)ocument or C)ancel" prompt. I've
posted the note about this on lynx-dev.
 
> > > By the way, I think that it would be better to make clear that what the
> > > command does is to change the _current_ directory by calling it "change
> > > current directory" everywhere and by changing SUPPORT_CHDIR to something
> > > like SUPPORT_CHCURDIR.
> > 
> >   I don't think that is right idea - what directory "change directory"
> >  command could change beside current?
> 
> Well, even you used "current directory" in your patch:
> 
> | +#KEYMAP:C:CHDIR            # Change current directory
> 
> + { "CHDIR",          "change current directory" },
> 
> That's why I said to change it _everywhere_. 
> 
> Actually, "current directory" is not a good name for it. The current
> directory is the one I'm on in a certain moment (in DIRED). I could have gone
> there with "g" or following links in DIRED. That "current directory" is the
> directory where you have run lynx from, the one you can (g)o to with "." and
> the one where files will be saved by default. What would be a good name for
> it? "default directory"? "base directory"? ". directory"? "original
> directory"? Any other ideas?

  Remember, 'C' while in dired automatically loads the content of the
directory specified by 'C' command, so "current dired directory" and "CHDIR's
current directory" are the same.
  And anyway, it's useless to rename all occurences of SUPPORT_CHDIR to
SUPPORT_CHCURDIR since it's preprocessor macro (like __CYGWIN__ or __unix__)
and is not visible to the user. The only visible place of possible change is
the name of the 'C' command as printed by 'K' (it's CHDIR) and probably in
lynx.cfg. I don't care what 'K' will list for 'C'.

> Another confusing thing is the text in userdefs.h: 
> 
> | + * SUPPORT_CHDIR provides CD command (bound to 'C' by default). It allows
> | + * changing directory to arbitrary location (if OS allows them). If dired
> | + * is enabled, user will be able to visit any directory and view any file
> | + * allowed accroding to file permissions or ACLs.
> 
> To do that one doesn't need the "C" command. One can use the "g" command or
> follow links in DIRED "to visit any directory and view any file allowed
> accroding to file permissions or ACLs."
 
 In case somebody provides lynx-based services (e.g. advanced BBS), they could
disable hrefs to parent dir in dired (configure option) and disallow 'g'
command. If under this setup dired is enabled (for some reason), then using
'C' command in dired user will be able to visit any directory (since when in
dired, 'C' command automatically 'g'oes to the directory specified by 'C'
command). So, 'C' is unacceptable in that configuration - that comment tells.

> >  Thanks for evaluating dev4. Seems nobody else uses it (probably Eduardo
> > uses it too).
> 
> I'm always using the latest version and I believe that many do the same. It's
> just that we're not finding many bugs... :-)

 As for me, I stick to 2.8.3dev14 since this is the last version where I've
ported hyphenation code to. I have to backport every patch I post here to that
version.
 
> Thank you.
> 
> Ismael
> -- 
>        ________________________________________________________________
>       |                                                                |
>       | ISMAEL CORDEIRO            | mailto:address@hidden        |
>       | Production sound mixer     | http://www.pubnix.net/~ismael/    |
>       | MontrИal - QuИbec - Canada | ftp://ftp.pubnix.net/users/ismael |
>       |________________________________________________________________|
> 
> 
> ; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden
> 

 Best regards,
  -Vlad


; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden