Re: lynx-dev Crash in popup menu

[pg]

In a recent note, Thomas Dickey said:

> Date: Sun, 23 Jul 2000 18:49:31 -0400
> 
> On Sun, Jul 23, 2000 at 04:25:15PM -0600, address@hidden wrote:
> > At ../../lynx2-8-4/src/LYStrings.c:720 is:
> >     #ifndef USE_SLANG
> >     PRIVATE WINDOW *my_subwindow;
> 
> ah.  (I wonder why it works for me).  You're right of course...
> I guess both ncurses and Solaris (the one I tested, anyway), don't
> mind the null pointer, and since we read from stdscr that makes the
> popup window vanish since it gets overwritten.
> 
> > then calls delwin(NULL) and delwin() doesn't like the NULL.

If you're right that I'm right, then this patch may be right.
Regardless, please review before integrating.

########################################################################
%%% Created Sun Jul 23 16:35:43 MDT 2000 by target lynx.patch. %%%
diff -bru orig/lynx2-8-4/src/LYStrings.c lynx2-8-4/src/LYStrings.c
--- orig/lynx2-8-4/src/LYStrings.c      Mon Jul 17 20:49:54 2000
+++ lynx2-8-4/src/LYStrings.c   Sun Jul 23 16:26:01 2000
@@ -706,7 +706,8 @@
 
 PUBLIC void LYsubwindow ARGS1(WINDOW *, param)
 {
-    if ((my_subwindow = param) != 0) {
+    if (param != 0) {
+        my_subwindow = param;
 #if defined(NCURSES) || defined(PDCURSES)
        keypad(param, TRUE);
 #if defined(HAVE_GETBKGD) /* not defined in ncurses 1.8.7 */
########################################################################

Thanks,
gil
-- 
StorageTek
INFORMATION made POWERFUL

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden