lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev [PATCH] CTRACE comma expression


From: pg
Subject: lynx-dev [PATCH] CTRACE comma expression
Date: Wed, 4 Apr 2001 09:18:59 -0600 (MDT)

In a recent note, Thomas Dickey said:

> Date: Wed, 4 Apr 2001 05:04:12 -0400
> 
> > But I notice my comma-expression has been converted to a compound-statement.
> > Was the comma-expression too bizarre, or did it threaten portability?
> 
> well (my head's not too clear right now) - iirc, the issue was related to
> whether I could ifdef-out the whole trace statement, that I noticed some
> inconsistency in the set of ifdef's and related variables and rewrote the
> whole thing.
> 
I know it was conflicting with other changes in that area in dev.19. Since
that's stabilized, I'm resubmitting it.

In dev<=19, CTRACE expanded to an expression.  In dev.20 it's a compound
statement.  This returns it to an expression, so it should be no worse
than dev.19.

If you ifdef-out the whole trace statement, it will still work in a
statement context -- "CTRACE(( ... ));" becomes a dummy statement --
nothing is left but the ";".  It will still fail in an expression
context -- "( CTRACE(( ... )), 0 )" fails for "unexpected comma".
But this would have been true at dev.19 or dev.20.

-- gil
-- 
StorageTek
INFORMATION made POWERFUL

Attachment: lynx.patch.comma
Description: ascii text


reply via email to

[Prev in Thread] Current Thread [Next in Thread]