Re: lynx-dev handling broken content-type specification in meta

[Vlad Harchev]

On Wed, 8 May 2002, David Woolley wrote:

> > LS0tIExZQ2hhclV0aWxzLmMtd2FzCVdlZCBNYXkgIDggMjE6MDA6MTkgMjAw
> > Mg0KKysrIExZQ2hhclV0aWxzLmMJV2VkIE1heSAgOCAyMTowNjoyMyAyMDAy
> 
> Pine strikes again with inappropriate content-transfer-encoding!
> (Patches are better in the main body - people reading this with 
> non-metamail based email programs probably had to explicitly open
> the attachment, as I'd have to do to comment on the plain text.)
> 
> I would describe this as a workaround, not a fix.  It's also
> the wrong workaround.  Almost certainly what the other browsers
> are doing is saying that the document must be some form of HTML,
> for them to have recognized META, so just completely ignore the
> media type and look for the charset parameter.
> 

 OK, I forgot a preffered way of sending patches to lynx-dev (I thought pine
could corrupt/wrap lines if inserted into the body of the mail). Though the
patch was so short that it won't make any difference in ease of commenting it
for people using metamail-based email programs.

 Yes, it seems other browsers ignore media type completely (just tried with
IE and "text-rtf" media type). Here is a fixed patch.
 But this patch is longer than previous :)

 Best regards,
  -Vlad

--- LYCharUtils.c-was   Wed May  8 21:00:19 2002
+++ LYCharUtils.c       Thu May  9 12:59:51 2002
@@ -2814,9 +2814,7 @@
        LYTrimTail(content);
        LYLowerCase(content);
 
-       if ((cp = strstr(content, "text/html;")) != NULL &&
-           (cp1 = strstr(content, "charset")) != NULL &&
-           cp1 > cp) {
+       if ((cp1 = strstr(content, "charset")) != NULL) {
            BOOL chartrans_ok = NO;
            char *cp3 = NULL, *cp4;
            int chndl;



; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden