patch, Re: lynx-dev www.habeus.com weird redirect

[Bela Lubkin]

Al Gilman wrote:

> I could not reproduce your experience.
> 
> Here's the bottom line after the redirects:
> 
> -- dump of information page showing properly formed link
> 
>              Lynx 2.8.4pre.5 (14 Jul 2001) ([1]pre-release version)

The two versions I tried are:

  Lynx Version 2.8.4dev.20 (01 Apr 2001)
  Lynx Version 2.8.5dev.9 (06 Oct 2002)

... which bracket the version you tried.  So that's odd.

> File that you are currently viewing
> 
>     Linkname: Welcome to Habeas
>          URL: http://www.habeas.com/
>      Charset: iso-8859-1
>       Server: Apache/2.0.39 (Unix) mod_perl/1.99_03-dev Perl/v5.6.1
>            PHP/4.2.2
>         Date: Thu, 28 Nov 2002 22:59:47 GMT
>     Last Mod: Wed, 27 Nov 2002 01:31:03 GMT
>     Content-Length: 4059 bytes
>     Owner(s): None
>         size: 54 lines
>         mode: normal
> 
> Link that you currently have selected
> 
>     Linkname: About Habeas
>          URL: http://www.habeas.com/about/overview.htm
> 
> -- end information page
> 
> In the trace I find the following
> 
> -- trace fragment
> 
> 
> getfile: getting http://www.habeas.com
> 
> HTParse: aName:`http://www.habeas.com'
>     relatedName:`'
> HTParse:      result:www.habeas.com
> fix_httplike_urls: URL 'http://www.habeas.com'
>              changed to 'http://www.habeas.com/'
> 
> -- end trace fragment
> 
> which clearly shows where what you are not getting is performed by my copy 
> of the program.

Thank you.  With this breadcrumb, I was able to track down the problem.

Unfortunately, it appears to be an optimizer bug in the SCO OpenServer
native C compiler.  :-(

The following patch fixes the problem.  I am not saying this is a
necessary patch, since its only purpose is to work around a
system-specific compiler bug.  Still, it does fix the problem, and
shouldn't cause trouble anywhere else.  It could also be argued that the
"fixed" version is clearer.  Certainly my compiler thinks so... ;-}

>Bela<

--- src/LYGetFile.c.orig        Sun Oct  6 17:43:28 2002
+++ src/LYGetFile.c     Fri Nov 29 00:06:05 2002
@@ -1581,7 +1581,7 @@
        }
        if (type == HTTP_URL_TYPE ||
            type == HTTPS_URL_TYPE) {
-           if ((slash-2) - strchr(doc->address, ':')) {
+           if ((slash-2) != strchr(doc->address, ':')) {
                /*
                 *  Turns out we were not looking at the right slash after all,
                 *  there must have been more than one "://" which is valid

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden