Re: GMP

[Gary V. Vaughan]

Hi Akim,

Excuse the late reply.  Busy with gnuprog2... and the elusive bu fix
in my last m4 cleanup patch.

On Tue, Sep 18, 2001 at 11:06:27PM +0200, address@hidden wrote:
> Gary, I'd like your approval.  It works fine on my machine, which has
> libgmp.  But maybe I'm wrong on the intentions: the TODO portions and
> what I wrote are not exxactly the same.

Hmm.  I have libgmp and gmp.h, and yet the new test fails with a
compilation error.  This unsets USE_GMP, and yet libgmp is
unconditionally linked into mpeval.so.

The TODO item refers to something slightly different, in that I think
mpeval should be built with libgmp if possible, or else the gmp
specifics #defined out, and an init function which has an init
function that errors out with "libgmp support was not compiled in" or
something.

The configury should always check for libgmp (no need for a switch to
comtrol that), and the appropriate parts of mpeval.c compiled
depending on the result.

> Index: ChangeLog
> from  Akim Demaille  <address@hidden>
> 
>       * config/gmp.m4 (AM_WITH_GMP): Rename as...
>       (AC_LIB_GMP): this.
>       By default, use gmp.
>       Massive revamping.
>       * configure.in: Adjust.
>       Use Automake conditionals for USE_GMP.
>       Always compute sizeof (long long int).
>       This was a bug BTW, as `eval' (not `mpeval') depends on it:
>       before, it was used _only_ if mpeval was not activated.
>       * modules/Makefile.am (pkglibexec2dir, +pkglibexec2_LTLIBRARIES)
>       (mpeval_la_LIBADD): New macros.
>       * modules/mpeval.c: No longer be conditioned by WITH_GMP.
>       Indent.
>       * tests/Makefile.am ($(srcdir)/$(TESTSUITE)): Create package.m4.
>       * tests/atlocal.in, tests/builtins.at: Depend upon USE_GMP, not
>       WITH_GMP.

This is an incremental improvement over what was there before, so no
harm in applying it.  I have more gmp stuff in my patch queue...
committing shortly.

Cheers,
        Gary.
-- 
  ())_. Gary V. Vaughan     gary@(oranda.demon.co.uk|gnu.org)
  ( '/  Research Scientist  http://www.oranda.demon.co.uk       ,_())____
  / )=  GNU Hacker          http://www.gnu.org/software/libtool  \'      `&
`(_~)_  Tech' Author        http://sources.redhat.com/autobook   =`---d__/