m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: branch-1_4: do not write in getenv result


From: Eric Blake
Subject: Re: branch-1_4: do not write in getenv result
Date: Tue, 10 Oct 2006 05:37:15 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Thunderbird/1.5.0.7 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ralf,

According to Ralf Wildenhues on 10/10/2006 4:21 AM:
> 
> The patch I posted did not try to free a non-malloced pointer, unlike
> the one that was committed:
> 
> $ M4PATH=/foo:/bar ./src/m4
> Segmentation fault (core dumped)

Sorry about that; I ported your path to head first, where the while loop
was factored into its own function, then ported my version instead of
yours back to head without realizing that the inline while loop changes
the pointer value.  :(

Your patch is now in, as posted.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFK4Xq84KuGfSFAYARAgYJAJ9+PEJpXb/6dL2JtREGLkOFPa045wCfTly3
1v8Cer4AG23PMzS/gGoA0Wo=
=48my
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]