m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNU M4 1.9a] testsuite: 52 59 60 61 62 failed


From: Eric Blake
Subject: Re: [GNU M4 1.9a] testsuite: 52 59 60 61 62 failed
Date: Sat, 14 Oct 2006 09:35:22 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Thunderbird/1.5.0.7 Mnenhy/0.7.4.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 10/14/2006 9:21 AM:
> 
> 2006-10-14  Eric Blake  <address@hidden>
> 
>       * m4/input.c (file_clean): Don't close stdin twice, POSIX says it
>       is not portable.
>       Reported by Ralf Wildenhues.

And of course, I now have to adjust the testsuite to match the new error
behavior.  Patch coming soon, but first I'm debating about refactoring the
code a bit to avoid a multi-line error:
$ m4 <&-
m4:stdin:1: error reading file `stdin'
m4: error closing stdin: Bad file descriptor
$ m4 - - <-
$ build/tests/m4 - - <&-
m4:stdin:1: error reading file `stdin'
m4:stdin:1: error reading file `stdin'
m4: error closing stdin: Bad file descriptor

I'm not sure if it would be cleaner to see just:
$ m4 - - <&-
m4: error reading file `stdin'

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFMQO584KuGfSFAYARAnOIAJ41sOZVEmc1dHwQSnS5HhBv9H8iSQCeNonh
m5HeuWbwJbJDXBUTfZJePPw=
=FH0j
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]