m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: failure with HEAD: stdin seekable


From: Gary V. Vaughan
Subject: Re: failure with HEAD: stdin seekable
Date: Mon, 18 Dec 2006 15:24:12 -0500

Hi Eric, Ralf,

On 18 Dec 2006, at 09:02, Eric Blake wrote:
According to Ralf Wildenhues on 12/17/2006 5:10 AM:

Thanks, the stdin seekable test is skipped now, but also the stdout full
one fails.

I see it on cygwin as well. The problem is that my added call to fflush ignores the errno, and while ferror tracks that something went wrong, the error message is now less descriptive. But warning during the flush is also wrong, as m4 should only need to error out once that stdout is full, rather than on every subsequent flush. I'm debating whether it is worth
capturing errno on flush, then referring to that on close; or just
changing the testsuite to match the new reality of the error message.

@@ -1,2 +1,2 @@
-m4: write error: No space left on device
+m4: write error

Unless the amount of work involved is prohibitive, better error messages
always win out IMHO.

Cheers,
        Gary
--
Gary V. Vaughan      ())_.  address@hidden
Research Scientist   ( '/   http://blog.azazil.net
GNU Hacker           / )=   http://www.gnu.org/software/{libtool,m4}
Technical Author   `(_~)_   http://sources.redhat.com/autobook




Attachment: PGP.sig
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]