Re: [PATCH 3/4] configure: add -Zargs-resp to LDFLAGS on OS/2

[Eric Blake]

On 11/18/2014 08:54 PM, KO Myung-Hun wrote:
> -Zargs-resp enables a response file support on OS/2.
> 
> * configure.ac (LDFLAGS): add -Zargs-resp on *-*-os2*.
> ---
>  configure.ac | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 6dca663..2ca1576 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -217,6 +217,8 @@ M4_WITH_DMALLOC
>  
>  AC_CONFIG_COMMANDS([stamp-h], [[test -z "$CONFIG_HEADERS" || date > 
> stamp-h]])
>  
> +AS_CASE([$host], [*-*-os2*], [LDFLAGS="$LDFLAGS -Zargs-resp"])
> +

You cannot assume $host is set unless you also guarantee that
AC_CANONICAL_HOST was called.  Gnulib happens to call it, but I wonder
if we should also explicitly call it prior to this line so that someone
copying it to another file doesn't run into problems.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature