make-alpha
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: addsuffix manual example wrong, se_implicit test 4 fails.


From: h.becker
Subject: Re: addsuffix manual example wrong, se_implicit test 4 fails.
Date: Sat, 04 Oct 2014 10:19:48 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130519 Icedove/17.0.5

On 10/04/2014 12:38 AM, John E. Malmberg wrote:
> Found another VMS specific bug in dir.c (dir_contents_file_exists_p)
> 
> This always returns that a file exists because first it calls
> downcase(filename) which replaces filename with a static pointer.
> 
> Then a few lines later only on VMS, it does:
>    df->name = strcache_add_len(downcase(d->d_name), len);
> 
> This overwrites where filename points with the lower case contents of
> d->d_name.
> 
> And finally a test is to see if d->d_name is the same as filename, and
> since they are both pointing at the same static storage, it results in
> the file being marked as found.

Yes, it is a bug, but I'm not sure whether downcase() is ONLY used for VMS.

Just before "my VMS system" disappeared from the net, I saw this too,
when I disabled vmsify() - which makes/uses a copy of 'filename'.

> On a future note, on current VMS, the Case sensitive filesystem
> attribute is a per process property, so we will need a global variable
> to contain the status.  I am not going to address that issue at this time.

... "is a per process property" but only affects the ODS5 filesystem
although in a recipe there can be ODS2 files for source and target files.

PS: Shouldn't this be posted on address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]