[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GMG-Devel] Review
From: |
Boris Bobrov |
Subject: |
[GMG-Devel] Review |
Date: |
Mon, 25 Jul 2016 02:42:51 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 |
Hi,
Here is short review. Unfortunatelly, i was not able to review too much
because of traceback.
1. Why is the plugin called "custom_subtitles"? :) I think it should be
"subtitles".
mediagoblin/plugins/custom_subtitles/tools.py:
2.
20 def get_path(path):
21 path = eval(path) # Converting string to a tuple
22 return path
2. Please don't use eval. Find another way. json might be a good choice.
3. Indentation in open_subtitle and save_subtitle is broken. Now when i
click "add subtitles" it doesn't work and i get a traceback.
To prevent errors like this i suggest to write some unit tests. Please
write some basic ones, that would upload subtitles and delete them.
Have a look at how video and audio are tested.
- [GMG-Devel] Review,
Boris Bobrov <=