parsing-error-strangeness

[Christian Hopp]

Hi!

Having a new monit syntax is a good situation to test monit's parsing
error behavior.  These are just some testing results:

1) Default poll time:

In case set daemon is omitted, monit does check one.  Poll time is set
to zero?  Is that behavior okay?

2) Errors at the end:

Consider this monitrc, with old syntax, thus erroneous:

--------------SNIP-------------
check process crond with pidfile /var/run/crond.pid
      depends ssh

check process ssh with pidfile /var/run/sshd.pid
      port 22 protocol ssh
--------------SNAP-------------

The error message is:
(address@hidden) ~/compile/monit/monit> ./monit -c ../monitrc-test-short -v -I
monit: syntax error '' at line 4
Exit 1

It should complain over line 5 and not with ''.

3) Depends beyond errors:

Now consider this monitrc, with old syntax, thus also erroneous:

--------------SNIP-------------
check process crond with pidfile /var/run/crond.pid
      depends inetd

check process ssh with pidfile /var/run/sshd.pid
      port 22 protocol ssh

check process inetd with pidfile /var/run/inetd.pid
--------------SNAP-------------

The result:

(address@hidden) ~/compile/monit/monit> ./monit -c ../monitrc-test-short -v -I
monit: syntax error 'check process ' at line 5
monit: Error, depend service 'inetd' is not defined in the control file
Exit 1

The first error is correct, but the second depend error is false.  It
can lead to confusion.

CHopp


-- 
Christian Hopp                                email: address@hidden
Institut für Elektrische Informationstechnik             fon: +49-5323-72-2113
TU Clausthal, Leibnizstr. 28, 38678 Clausthal-Zellerf.   fax: +49-5323-72-3197
                             pgpkey: https://www.iei.tu-clausthal.de/pgp-keys/