Re: SIGSEGV problem

[Jan-Henrik Haukeland]

Christian Hopp <address@hidden> writes:

> On Thu, 14 Aug 2003, Jan-Henrik Haukeland wrote:
>
>>
>> I ran a fast test with efence and managed to reproduce the SIGSEGV (it
>> may be more). SIGSEGV is thrown in process/common.c:connectchild()
>> from this line:
>>
>>  parent->children[parent->children_num - 1] = (struct myprocesstree *) child;
*
> I gonna have a look at it. (-:

Great, btw, did you have time to look at the line number problem
caused by the DEPEND_COND sub-condition in the lexer as well? If not I
can try to look at it when I get back later this evening.

>> BTW, Christian why do you use cast in this code!? I'm thinking about
>> stuff like (struct myprocesstree ..) It is *not* necessary.
>
> because it usually does not harm either.

IMHO stuff like this adds cruft to the code and is orthogonal to the
"keep it as simple as possible" principle :) Pretty please, with sugar
on the top, remove it, and also any similar redundant cast code :-)

-- 
Jan-Henrik Haukeland