monit-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

replace finalize_files() ?


From: Martin Pala
Subject: replace finalize_files() ?
Date: Sun, 14 Sep 2003 19:19:47 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030908 Debian/1.4-4

Hi,

i think it could be good to replace finalize_files() function with direct call of unlink(Run.pidfile). The present implementation does exactly the same thing:

--SNIP--
/**
* Remove temporary files
*/
void finalize_files() {

 unlink(Run.pidfile);

}
--SNIP--

In the code are on the same level as finalize_files() called other standalone file handling functions for similar intent - such as state_finalize(), log_close(), etc. I think there is no reason to keep it - the code can be more clear without it and the code can be faster without it (it will not improve performance very much, but why to pay for something, which is not necesary :)

May we replace it?

Martin






reply via email to

[Prev in Thread] Current Thread [Next in Thread]