Re: syntax change proposal

[Jan-Henrik Haukeland]

Martin Pala <address@hidden> writes:

> Here is the solution. If you agree, i can sync it. This patch solves
> the only drawback in new event engine which i knew about.

These changes seems reasonable, the only consideration I have is the
checksum statement. It may be interesting to have a IF CHANGED
CHECKSUM statement but in most cases a checksum change is an error so
this statement will be used in most cases:

 IF FAILED [hashtype] CHECKSUM EXPECT STRING THEN action

But as far as I can see from the patch (I may be wrong, I just had a
quick browse) the above statement will, if failed, continue to raise
alerts on every poll cycle. The best thing to do is what we did
before, raise one alert and set the old value to the new, silently
ignoring the excpect string. In other words treat it the same way as
you do with IF CHANGED CHECKSUM. The important thing is to avoid alert
flooding on errors (for all statements).

Other than this minor change to the patch, it looks good. You have
really been busy lately fixing lots of stuff :-) and as far as I can
see these are all very good changes and improvements to monit.

Here's my +1 pending a fix on the consideration raised

-- 
Jan-Henrik Haukeland