[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] [patch] netio.hh
From: |
Adam Logghe |
Subject: |
Re: [Monotone-devel] [patch] netio.hh |
Date: |
Fri, 14 May 2004 08:35:15 -0700 |
User-agent: |
Mozilla Thunderbird 0.5 (X11/20040306) |
I assume this related? I got the first error about 9pm PST last night on
both the linux and win32 client and then the next one this morning (only
tried linux this morning)....
address@hidden:~/Code$ monotone --db=monotone.db --key="" pull off.net
net.venge.monotone
monotone: warning: doing anonymous pull
monotone: rebuilding merkle trees for collection net.venge.monotone
monotone: including branch net.venge.monotone
monotone: including branch net.venge.monotone.i18n
monotone: including branch net.venge.monotone.win32
monotone: [keys: 8] [mcerts: 1088]
monotone: connecting to off.net
monotone: [bytes in: 122036] [bytes out: 14868]
3
######
LOTS OF DB ACTIVITY DUMPED--Let me know if you actually want it......
######
db.fetch("SELECT id FROM 'file_deltas' WHERE id =
'446275b7dbb9d93b72342bf1cfb103c22d73d9a6'")
db.fetch("SELECT id FROM 'files' WHERE id =
'446275b7dbb9d93b72342bf1cfb103c22d73d9a6'")
db.fetch("SELECT id FROM 'file_deltas' WHERE id =
'446275b7dbb9d93b72342bf1cfb103c22d73d9a6'")
db.fetch("SELECT id FROM 'files' WHERE id =
'446275b7dbb9d93b72342bf1cfb103c22d73d9a6'")
db.execute("INSERT INTO 'files'
VALUES('446275b7dbb9d93b72342bf1cfb103c22d73d9a6', ...")
processing 19259 byte input buffer from peer off.net
received 'bye' netcmd
processing 19229 byte input buffer from peer off.net
netio.hh:31: invariant 'I(pos < str.size())' violated
db.execute("ROLLBACK")
**** exception(205): std::logic_error: netio.hh:31: invariant 'I(pos <
str.size())' violated
******** errors detected; see standard output for details ********
####
Then this morning....
####
address@hidden:~/Code$ monotone --db=monotone.db --key="" pull off.net
net.venge.monotone
monotone: warning: doing anonymous pull
monotone: rebuilding merkle trees for collection net.venge.monotone
monotone: including branch net.venge.monotone
monotone: including branch net.venge.monotone.i18n
monotone: including branch net.venge.monotone.win32
monotone: [keys: 8] [mcerts: 1088]
monotone: connecting to off.net
monotone: [bytes in: 6126] [bytes out: 9251]
monotone: read from fd 7 (peer off.net) failed, disconnecting
Adam
graydon hoare wrote:
> this changes netio.hh to accomodate 0-byte command packets; they seem to
> happen sometimes, I haven't tracked down where just yet. it's probably a
> small bug in netsync itself, but it seems to be preventing some people
> from doing a sync at the moment.
>
> -graydon
>
>
>
> ------------------------------------------------------------------------
>
> # Old manifest: 3237bd47b6a1885ea1095d0148109cee0b7addd1
> # New manifest: 78e5e8a2cd346bbd16357a9a258d3aee51d399e9
> # Summary of changes:
> #
> # patch netio.hh
> # from 56ceb678186b7cc9164ffead71629e80a3e33b23
> # to 2d374c1a00dc50c0be103d04449cc204534c8636
> #
> --- netio.hh
> +++ netio.hh
> @@ -28,9 +28,11 @@
> {
> // if you've gone past the end of the buffer, there's a logic error,
> // and this program is not safe to keep running. shut down.
> - I(pos < str.size());
> + I(pos < str.size() || (pos == str.size() && len == 0));
> // otherwise make sure there's room for this decode operation, but
> // use a recoverable exception type.
> + if (len == 0)
> + return;
> if (str.size() < pos + len)
> throw bad_decode(F("need %d bytes to decode %s at %d, only have
%d")
> % len % name % pos % (str.size() - pos));
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Monotone-devel mailing list
> address@hidden
> http://mail.nongnu.org/mailman/listinfo/monotone-devel