Re: [Monotone-devel] monotone disapprove does not give correct branch cert

[Emile Snyder]

Yuck.  cert.cc:guess_branch(revision) defaults to using
app.branch_name() if one is set; ie. you are in a working copy.
There are 4 commands using guess_branch to decide how to cert a new
revision:

approve
disapprove
checkout
commit

I would argue that only commit should default to using the working copy
value if one is set.  approve and disapprove both take a revision as a
specific argument; I can sort of see using the value of the working copy
branch if that given revision has no branch cert, but not the other way
around.

Am I missing something?

thanks,
-emile

On Tue, 2005-10-25 at 16:52 +0200, Wim Oudshoorn wrote:
> In our repository we have a few revisions with no branch certificate.
> It seems that they are caused by using
> 
> monotone disapprove REVISION
> 
> AFAICT monotone disapprove tries to figure out the branch
> from the current working directory and uses that branch
> to certify the disapprove node.  
> If the command is given outside any working tree it 
> does not give any branch certificate to the disapprove node.
> 
> Wim Oudshoorn.
> 
> 
> 
> _______________________________________________
> Monotone-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monotone-devel
>