Re: [Monotone-devel] [PATCH] Add a commit message validation hook

[Blake Kaplan]

On 1/25/06, Nathaniel Smith <address@hidden> wrote:
> Comments:
>   -- the passing of added/deleted/modified seems a bit arbitrary; why
>      those and not renames, attrs sets, attr deletes?  What if the
>      code cares about the difference between added files and dirs?

It's totally arbitrary :-).

>      1) Is there a particular use case being supported?

Alas, I don't know of any specific use cases for this hook, so I'm
working towards what I think should be the simplest functional hook.

>      2) Maybe it would make more sense to just pass the text of the
>         revision, since lua already has a function to let people parse
>         it themselves if they want this info?

Yeah, this makes a lot more sense.

>   -- Could you add a test or two?  tests/README is a quick-start
>      guide.

testsuite -l seems to segfault in my vmware-powered Linux environment,
but the test here seems to pass and test some of the more important
parts of the hook.

> Perhaps we should expose some basic output stuff to lua, like our...

The rest of this sounds like good ideas that I'll tackle in separate
patches. I've attached an updated patch which should address the above
message.
--
Blake Kaplan

validate-commit.diff
Description: Text Data