[Monotone-devel] Re: Question for Tim - testsuite.lua giant list

[Bruce Stephens]

"Zack Weinberg" <address@hidden> writes:

> Is the giant list of test cases in testsuite.lua there because there's
> no readdir() equivalent in Lua's standard library,

Seems likely.

> or is there some better reason?
>
> If it's the former, does anyone object to my snarfing Steve Kemp's
> lua-fs extension[1] into our local copy of the interpreter, and using
> that to get rid of the giant list?  (Note I can see this being useful
> for hooks too - it has other useful things like stat, chmod, mkdir -
> which is why I suggest grabbing the whole thing rather than just the
> readdir implementation.)

In the past there's been concern about allowing lua commands that have
too much ability to cause damage, presumably on the grounds that
people might grab hooks without looking carefully at them.

I'm not sure whether that still applies or not; and perhaps there's a
clean way to enable them in the test suite without having them
available in hooks.