[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Re: RFC: workspace migration and work.cc refactor [
From: |
Derek Scherger |
Subject: |
Re: [Monotone-devel] Re: RFC: workspace migration and work.cc refactor [net.venge.monotone.workspace-merge.migration] |
Date: |
Mon, 31 Jul 2006 23:17:56 -0600 |
User-agent: |
Thunderbird 1.5.0.4 (X11/20060605) |
Zack Weinberg wrote:
> now is that a small minority of app.work.foo() calls take an app_state
> reference and there's no rhyme nor reason to which of them it is; thus
> the thought that it might be better to put a reference to the entire
> app_state into the workspace object. [It would not help to add more
> sub-component references, because the primary remaining use of
> app_state is to construct node_restriction objects.]
If it helps, the restrictions stuff only uses app.lua (for the
ignore_file hook) and the app.depth option setting. It doesn't touch
anything else in app_state so there's really no need to pass the whole
thing in.
Cheers,
Derek