Re: [Monotone-devel] [PATCH] New lua command execute_redirout which executes an os command and captures standard output

[Daniel Dickinson]

On Mon, Aug 14, 2006 at 01:09:18AM -0500, Timothy Brownawell wrote:
> On Mon, 2006-08-14 at 01:00 -0400, Daniel Dickinson wrote:
> "mtn revert po". I hear the translators don't like people committing
> changes to these files anyway, so you will want to do that eventually.
> po/ seems to only get modified on a fresh build, so you shouldn't have
> to keep doing this every time.

Ok.  Thanks.
 
> Or do "mtn diff --exclude po".
> 
> > Comments on the code are welcome, and I'll make any changes, hopefully
> > quickly enough to get into 0.29.
> 
> It's horribly large, which is completely not needed.
> 
> I'd suggest just making process_spawn_redirected take an empty filename
> as meaning to not redirect that stream, so your execute_redirout does
>    local outfile = mkstemp()
>    spawn_redirected("", outfile, "", <program and args>)
>    output = readfile(outfile)

Erm, but I think mkstemp returns a file handle  and spawn_redirected
takes a filename which it opens (and truncates) or creates, so you
can't simply feed the output of lua's mkstemp() into spawn_redirected
unless lua file handles are just filenames.

-- 
GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C      http://gnupg.org
And that's my crabbing done for the day.  Got it out of the way early, 
now I have the rest of the afternoon to sniff fragrant tea-roses or 
strangle cute bunnies or something.   -- Michael Devore

signature.asc
Description: Digital signature