Re: [Monotone-devel] missing directories

[Nathaniel J. Smith]

On Tue, Dec 26, 2006 at 10:19:28PM -0700, Derek Scherger wrote:
> I vaguely recall someone wondering why monotone doesn't notice when an 
> empty versioned directory is missing a while ago and this seems like 
> something we probably should be doing. i.e. monotone will currently 
> abort in update_current_roster_from_filesystem if there are any missing 
> files but will not notice if there are missing directories if they don't 
> happen to also contain versioned files.
> 
> The attached patch changes update_current_roster_from_filesystem 
> slightly so that it will abort if there are missing directories, whether 
> they contained files or not. It also makes some slight tweaks to the 
> associated messages so they're a bit more specific about missing things 
> verses things that are not what they should be, like files that should 
> be directories and vice-versa.

Do we have any tests for this error?

> Are there any objections to this change? Should I hold off until 0.32 
> has been rolled? It will probably have a slight impact on translations 
> because of the messaging changes.

It looks good to me.  One quibble: does anyone care that they have 7
missing files and 3 missing directories?  Is there any reason not to
just tell the user they have "10 items missing" or something like
that?

-- Nathaniel