[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] PATCH: note_netsync_revision_received apparently mi
From: |
Nathaniel Smith |
Subject: |
Re: [Monotone-devel] PATCH: note_netsync_revision_received apparently missing author cert |
Date: |
Tue, 13 Mar 2007 12:37:51 -0700 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Tue, Mar 13, 2007 at 11:33:51AM +0000, Bruce Stephens wrote:
> --- lua_hooks.cc 9f844c1bf6692f8bb488e5a596caa2f622f8a454
> +++ lua_hooks.cc 6359909e6058a18614b49e0a02967d5725fdb10e
> @@ -841,7 +841,7 @@ lua_hooks::hook_note_netsync_revision_re
> int n=0;
> for (cdat::const_iterator i = certs.begin(); i != certs.end(); ++i)
> {
> - ll.push_int(n++);
> + ll.push_int(++n);
> ll.push_table();
> ll.push_str("key");
> ll.push_str(i->first());
If we keep making this mistake, then maybe we should have some sort of
lua table creation helper functions and use those everywhere?
-- Nathaniel
--
"But suppose I am not willing to claim that. For in fact pianos
are heavy, and very few persons can carry a piano all by themselves."