monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [PATCH] fix test "syntax_errors_in_.mtn-ignore"


From: Zack Weinberg
Subject: Re: [Monotone-devel] [PATCH] fix test "syntax_errors_in_.mtn-ignore"
Date: Wed, 10 Oct 2007 08:51:05 -0700

On 10/10/07, Ralf S. Engelschall <address@hidden> wrote:
> A "make check" on h:n.v.m currently results in one failed test:
> "syntax_errors_in_.mtn-ignore". The reasons is because the test performs
> a "mtn ls unknown" command and checks the stderr output. Unfortunately,
> it doesn't seem to be deterministic in what order the files are checked
> against the Lua function ignore_file() and hence the first line ("mtn:
> warning: while matching file 'XXXX':") of the stderr output of "mtn ls
> unknown" contains an abitrary filename "XXXX" and hence lets the test
> fail. There are multiple possibilities to fix this. I propose to simply
> skip the first line of stderr during output comparisons:

That's the right fix in principle but I think there is a more elegant
way to implement it.  Stay tuned...

zw




reply via email to

[Prev in Thread] Current Thread [Next in Thread]