Re: [Monotone-devel] database_class_cleanup.patch

[William Uther]

On 06/11/2007, at 7:11 AM, Tobias Hunger wrote:

> Hello!
>
> I spend some time this weekend getting my feet wet with monotone. I  
> did some
> janitor stuff and cleaned up the database.(hh|cc) files. I further  
> cleaned up
> some header dependencies (where I stumbled over them while cleaning  
> up the
> headers included in database).
>
> STATUS:
> --------
>
> The testsuite has 7 unexpected fails due to me breaking rcs_import.  
> This
> functionality depends on interfaces private to the database class.
>
> TODO:
> -------
>
> Fix rcs_import.cc: I think we should extend the database public  
> interface to
> provide the functionality required by rcs_import.
>
> The other option I see is removing rcs_import altogether: It is  
> marked as a
> debug functionality and as such shouldn't see widespread use. Tailor  
> and
> other tools do a better job anyway:-)
>
> What do you think? Which way to go?

Without having looked at you patch, and hence an admittedly somewhat  
uninformed opinion, I'd remove rcs_import.  Or rather, move it to a  
separate program that uses the automate interface...  like the  
cvs_sync branch.

Be well,

Will        :-}