[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] ikiwiki monotone support
From: |
Brian May |
Subject: |
Re: [Monotone-devel] ikiwiki monotone support |
Date: |
Sun, 17 Feb 2008 20:08:08 +1100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) |
>>>>> "William" == William Uther <address@hidden> writes:
William> I think the "Monotone_rcs_support" bug got marked as
William> closed and it just got forgotten about. I haven't chased
William> it up. There is still more work that could be done with
William> links to ViewMTN and making sure the commit emails work,
William> so I wasn't too fussed that the incremental stuff didn't
William> get committed.
I got most of the changes applied.
The commit email stuff was discarded, because email notifications have
been removed from ikiwiki.
I am uneasy about this change though, the change for to update the
wiki from the monotone hook:
http://git.ikiwiki.info/?p=ikiwiki;a=commitdiff;h=1c06aed378e579b7396937fdff4e38ea0482ff5b;hp=8f7d7c1a00d65fcdb1482f5e8ce334be752c3db4
It is a bit better then the original patch... which was intended to
have the monotone wrapper script in the path somewhere.
Why put the hook into _MTN/mergerc instead of _MTN/monotonerc?
As such, the hook won't get used unless specified. From memory
_MTN/monotonerc is read by default.
* Could all the hooks get moved into _MTN/monotonerc?
* Or is it better just to add the note_netsync_revision_received hook
in _MTN/monotonerc?
I confess I am not really sure what the mergerc stuff does.
For reference, the latest copy of the file is also available:
http://git.ikiwiki.info/?p=ikiwiki;a=blob;f=IkiWiki/Rcs/monotone.pm;hb=HEAD
Also, related, I suspect this part of the patch might have got missed,
but before I ask Joey to fix this, I want to resolve the above. This
change may not be required.
@@ -186,8 +186,9 @@ sub rcs_update () { #{{{
check_config();
if (defined($config{mtnsync}) && $config{mtnsync}) {
+ check_mergerc();
if (system("mtn", "--root=$config{mtnrootdir}", "sync",
- "--quiet", "--ticker=none",
+ "--quiet", "--ticker=none", "--rcfile",
$config{mtnmergerc},
"--key", $config{mtnkey}) != 0) {
debug("monotone sync failed before update");
}
--
Brian May <address@hidden>
- Re: [Monotone-devel] ikiwiki monotone support,
Brian May <=
- Re: [Monotone-devel] ikiwiki monotone support, William Uther, 2008/02/17
- Re: [Monotone-devel] ikiwiki monotone support, Brian May, 2008/02/21
- Re: [Monotone-devel] ikiwiki monotone support, Brian May, 2008/02/22
- Re: [Monotone-devel] ikiwiki monotone support, Brian May, 2008/02/22
- Re: [Monotone-devel] ikiwiki monotone support, Brian May, 2008/02/22
- Re: [Monotone-devel] ikiwiki monotone support, William Uther, 2008/02/24
- Re: [Monotone-devel] ikiwiki monotone support, Brian May, 2008/02/25