Re: [Monotone-devel] [PATCH] Quickie: list duplicates

[Thomas Keller]

Hi Tero!

> To learn more about Monotone internals, I implemented the "list duplicates"
> command from the QuickieTasks wiki page.

Cool, very nice!

> It is not optimized for speed, but should work as expected.
> I also included a few tests and a section for the manual.
> 
> The patch is attached and also available at
> http://iki.fi/tero.koskinen/monotone/monotone_list_duplicates_v1.diff

The code looks great overall - just three small things:

1) Please remove the extra whitespace before opening brackets, f.e.
"paths.push_back (p);" should just be "paths.push_back(p);"

2) Personally I'd find it easier for the eye to catch if the fileid
would not be repeated in every line of the output, but would be only
printed for the very first occurence

3) In the manual section I'd add a sentence how this calculation works,
i.e. what "duplicate files" means to monotone - something like "Two or
more files are considered duplicates if their contents are equal, i.e.
have an identical content hash."

Other than that its ready to commit. Do you already have commit rights
on monotone.ca?

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature